Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for kubeadm integration with kustomize #1379

Closed
timothysc opened this issue Jan 31, 2019 · 10 comments
Closed

Tracking issue for kubeadm integration with kustomize #1379

timothysc opened this issue Jan 31, 2019 · 10 comments
Assignees
Labels
area/UX kind/feature Categorizes issue or PR as related to a new feature. kind/tracking-issue lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@timothysc
Copy link
Member

timothysc commented Jan 31, 2019

This a FEATURE REQUEST?

A number of feature requests we've had over time have all centered around the idea plumbing through options into what eventually becomes the end-state of a pile of YAML. Some things make sense to expose as knobs, but other things don't.

The purpose of this issue is to explore the option and impact of what is would mean to add a kustomize step @ certain phases of YAML generation.

@neolit123 @fabriziopandini @luxas

design proposal (tracking issue/KEP): kubernetes/enhancements#1177

@timothysc timothysc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 31, 2019
@timothysc timothysc added this to the Next milestone Jan 31, 2019
@luxas
Copy link
Member

luxas commented Feb 2, 2019

I'm not gonna have time to work on this quite yet, doing the other refactoring of the other components to use componentconfig first

@fabriziopandini
Copy link
Member

This is indeed a good idea, even if currently the pile of yaml is super fragmented across the kubeadm code base, and not always managed consistently.

So it is important to decide since the beginning if we want kustomize applied selectively or if we should go for a deeper refactor: First generate all yamls, then kustomize, then apply to the cluster (kubeadm 2.0)

Another thing we should define is what kind of support is provided for Kustomized cluster (for join/upgrades)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2019
@neolit123
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2019
@neolit123 neolit123 added area/UX priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 27, 2019
@neolit123 neolit123 modified the milestones: Next, v1.16 Jun 27, 2019
@neolit123 neolit123 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2019
@randomvariable
Copy link
Member

randomvariable commented Jul 3, 2019

This is also potentially part of #683 for some recommended options.

In particular there is a need to customise the static pod manifests created by kubeadm

@neolit123 neolit123 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 18, 2019
@jfbai
Copy link

jfbai commented Jul 20, 2019

Is there any design proposal or PR for this feature request?

@fabriziopandini
Copy link
Member

fabriziopandini commented Jul 22, 2019

@neolit123
Copy link
Member

neolit123 commented Aug 3, 2019

@fabriziopandini i renamed the ticket and added kind/tracking issue.
please keep the OP updated with a list of PRs and TODO tasks.

@fabriziopandini
Copy link
Member

done in 1.16
/close

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

done in 1.16
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UX kind/feature Categorizes issue or PR as related to a new feature. kind/tracking-issue lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

8 participants