Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review kubeadm package layout #1205

Closed
fabriziopandini opened this issue Oct 31, 2018 · 10 comments
Closed

Review kubeadm package layout #1205

fabriziopandini opened this issue Oct 31, 2018 · 10 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 31, 2018

as per comment kubernetes/kubernetes#70346 (comment) and kubernetes/kubernetes#70333 (comment)

If there is consensus, kubeadm package layout should be aligned with other Kubernetes commands.

  • cmd/kubeadm should be used only for the UX
  • pkg/kubeadm should be introduces and host apis and all the other kubeadm packages

Additionally IMO:

  1. phases (an UX concept) should not be reflected in the pkg/kubeadm sub tree
  2. existing weirdness should be fixed (e.g. update inside /phases and vice-versa preflight outside /phases)
  3. Everything code for UX should be removed from pkg/kubeadm (e.g. printf/kubeadm output)
  4. util is abused/too crowded. it should be simplified.
  5. documentation about what is the scope of each package should be added
  6. expose the kubeadm backend as vendorable API (xref)
@fabriziopandini fabriziopandini added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 31, 2018
@fabriziopandini fabriziopandini added this to the v1.14 milestone Oct 31, 2018
@yuexiao-wang
Copy link

Do it have a decision ?

@yuexiao-wang
Copy link

It is a similar issue about test utilites. #1257

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Dec 4, 2018

Not yet.
I think that this will be discussed in v1.14 planning (this week or the week after kubeconfig)

It is a similar issue about test utilites. #1257

Similar, but not overlapping

@yuexiao-wang
Copy link

yuexiao-wang commented Dec 4, 2018

Got it. kubernetes/kubernetes#71702, which fixes for #1257, will be hold and wait for v1.14 planning.

@MalloZup
Copy link

@fabriziopandini I would like to help on this. We might split this issue in small actionables issues. If you want we can talk about it in irc or here as you wish.

@fabriziopandini
Copy link
Member Author

@luxas considering that this cycle seems there are people willing to help, it will be great to hear what do you think about this idea...

Cleaning up some tech debt and getting in better shape for enabling kubeadm vendoring in future are the main reason behind this.
What about trying to combine a meeting for a quick brainstorming on this topic?

@timothysc timothysc modified the milestones: v1.14, v1.15 Feb 7, 2019
@timothysc timothysc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 7, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2019
@neolit123 neolit123 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 8, 2019
@timothysc timothysc modified the milestones: v1.15, Next May 10, 2019
@astrieanna
Copy link

/remove-help

because it isn't clear from the comments here if there is consensus or exactly what that consensus is.

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 10, 2019
@neolit123 neolit123 added the kind/design Categorizes issue or PR as related to design. label May 30, 2020
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Oct 1, 2020

/close
in favor of #2316; before talking about implementation detail, we should discuss the use cases we want to address with the new package layout

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: Closing this issue.

In response to this:

/close
in favor of #2316

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

8 participants