-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: add resource recommendation #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's more generous than what I read out of the tests, I basically meant "start with 200MB, start scaling up if you have more than 100 nodes". but no big harm in being generous I guess?
Agreed. What I wanted to avoid is people giving their kube-state-metric 6mb request and limit. 200mb will get you very far from our findings. |
hmm but in the way you phrased it, I would expect that I need 206MiB for a 3 node cluster, so I'd probably add even more, and then it does get a bit excessive. What do you think about
This makes it easier for people with "small" clusters, and the math checks out the same. The minimum CPU request is higher just to make things match up nicely, if someone really cares about reclaiming those 0.09 cores they will want to see what exactly they need. |
1743299
to
e227a59
Compare
Fair enough, I like your version better 🙂. Adapted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewception
Adjust the deployment to match the recommended resources (kubernetes#196). The baseline resources are set to the basic recommendation for a 100 node cluster. Pod nanny does not support "the baseline includes the first 100 nodes", so instead set the threshold until it needs to adjust wide. This over-estimates resource needs for intermediate cluster sizes, but I'd rather be on the safe side.
Adjust the deployment to match the recommended resources (kubernetes#196). The baseline resources are set to the basic recommendation for a 100 node cluster. Pod nanny does not support "the baseline includes the first 100 nodes", so instead set the threshold until it needs to adjust wide. This over-estimates resource needs for intermediate cluster sizes, but I'd rather be on the safe side.
Adjust the deployment to match the recommended resources (kubernetes#196). The baseline resources are set to the basic recommendation for a 100 node cluster. Pod nanny does not support "the baseline includes the first 100 nodes", so instead set the threshold until it needs to adjust wide. This over-estimates resource needs for intermediate cluster sizes, but I'd rather be on the safe side.
…tion README: add resource recommendation
Adjust the deployment to match the recommended resources (kubernetes#196). The baseline resources are set to the basic recommendation for a 100 node cluster. Pod nanny does not support "the baseline includes the first 100 nodes", so instead set the threshold until it needs to adjust wide. This over-estimates resource needs for intermediate cluster sizes, but I'd rather be on the safe side.
Based on @matthiasr's comment.
@fabxc @andyxning
This change is