-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation notice for support of Terraform v0.11 #9989
Add deprecation notice for support of Terraform v0.11 #9989
Conversation
Hi @bmelbourne. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @rdrgmnzs |
/approve Thanks for doing this! I wonder if we should also log a warning in kops 1.19 when someone uses the deprecated behavior via |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmelbourne, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
3 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
@bmelbourne I think your branch is missing #9988. Could you rebase so that docs tests pass? |
Thanks @bmelbourne . |
As of Nov 9th 2019, HashiCorp is starting a phased approach to deprecate support of Terraform v0.11 in Terraform providers.
https://www.hashicorp.com/blog/deprecating-terraform-0-11-support-in-terraform-providers
This deprecation notice should be merged in kops v1.19 prior to the merge of PR #9940 in kops v1.20.