-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove force_tcp flag for nodelocalcache dot zone #9917
Remove force_tcp flag for nodelocalcache dot zone #9917
Conversation
Forcing all DNS communication go through TCP can lead to increased latency and slower DNS responses since a lot of upstream DNS servers are not optimized for TCP traffic. An example is AWS's VPC DNS server that sending all the DNS traffic through TCP cause it to increase the latencies for this requests. The kubernetes version has already changed this configmap to skip force_tcp flag for the . zone, so it makes sense to follow their example. Reference https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml#L100
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @astrikos! |
Hi @astrikos. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Are you able to sign the CLA? |
I signed it /check-cla |
/assign @rifelpet |
/lgtm Thanks for this! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astrikos, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…17-origin-release-1.18 Automated cherry pick of #9917: Remove force_tcp flag for nodelocalcache dot zone
This PR is proposing a change in the nodelocalcache confimap.
The change is removing the
force_tcp
flag from the.
zone that handles all external DNS requests.Using the current nodelocalcache configuration we have experienced increased latencies for our DNS requests that needs to go to our upstream DNS server (which in our case is AWS VPC's DNS servers).
Forcing all DNS communication go through TCP can lead to increased latency and slower DNS responses since a lot of upstream DNS servers are not optimized for TCP traffic.
An example is AWS's VPC DNS server that sending all the DNS traffic through TCP cause it to increase the latencies for this requests.
The kubernetes version has already changed this configmap to skip
force_tcp
flag for the . zone, so it might make sense to follow their example.Reference https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/nodelocaldns/nodelocaldns.yaml#L100