Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the BootstrapClient task to run after Protokube #9911

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Allow the BootstrapClient task to run after Protokube #9911

merged 3 commits into from
Sep 14, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 10, 2020

Fixes: #9896

/cc @johngmyers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 10, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2020
@hakman hakman force-pushed the fix-gossip branch 2 times, most recently from 29edfc7 to 5a9a7b1 Compare September 11, 2020 04:02
johngmyers
johngmyers reviewed Sep 11, 2020
View reviewed changes
pkg/model/iam.go Show resolved Hide resolved
upup/pkg/fi/nodeup/nodetasks/service.go Outdated Show resolved Hide resolved
upup/pkg/fi/nodeup/nodetasks/service.go Outdated Show resolved Hide resolved
@mikesplain
Copy link
Contributor

I was bit by this a few days ago for some internal work. Glad to see you're working on a fix! Just tested and looks good to me!

/lgtm
/hold in case @johngmyers has more comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2020
@hakman
Copy link
Member Author

hakman commented Sep 12, 2020

Thanks @mikesplain will wait for the OK from @johngmyers and will cut the alpha.4 once this is merged.

@hakman hakman requested a review from johngmyers September 12, 2020 05:16
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2020
@hakman
Copy link
Member Author

hakman commented Sep 14, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2020
@hakman
Copy link
Member Author

hakman commented Sep 14, 2020

/test pull-kops-e2e-k8s-containerd
/test pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot k8s-ci-robot merged commit a93febf into kubernetes:master Sep 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Sep 14, 2020
@hakman hakman deleted the fix-gossip branch October 11, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@mikesplain mikesplain

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Worker nodes fail to join cluster in HA mode
4 participants
@hakman @k8s-ci-robot @mikesplain @johngmyers