Update k8s dependencies to v1.19.0 #9824
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
force-pushed
the
upd-deps-1.19.0
branch
from
2895dd3 to
5c7334f
Compare
k8s-ci-robot
added
size/XL
|
|
||
| replace k8s.io/code-generator => k8s.io/code-generator v0.19.0-rc.4 | ||
| replace k8s.io/code-generator => k8s.io/code-generator v0.19.0 | ||
|
|
||
| replace github.com/gophercloud/gophercloud => github.com/gophercloud/gophercloud v0.11.0 |
There was a problem hiding this comment.
Could you try remove this line? It shouldn't be necessary now that k8s doesn't directly depend on it. gomod should hopefully just use the version we specify and there should only be one line in go.sum.
There was a problem hiding this comment.
Not yet :)
go: k8s.io/[email protected] requires
k8s.io/[email protected] requires
k8s.io/[email protected]: reading k8s.io/code-generator/go.mod at revision v0.0.0: unknown revision v0.0.0
There was a problem hiding this comment.
We should keep an eye on this and upgrade when it is released:
kubernetes/cloud-provider-openstack#1151
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
/cc @rifelpet