Mock create server should associate with mock ports #9798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
olemarkus
force-pushed
the
openstack-newer-nova-5
branch
from
917c25f to
8e5e3d4
Compare
rifelpet
reviewed
Aug 22, 2020
| w.WriteHeader(http.StatusNotFound) | ||
| return | ||
| } | ||
| if _, ok := m.ports[portID]; !ok { |
There was a problem hiding this comment.
This is duplicate with a few lines above
There was a problem hiding this comment.
Thanks for catching. Duplicate removed.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a server, one passes in a port ID. The device ID of that port is then updated to the server id. Implementing this in the mock so we can test floating IP association later on.
Ran into a bit of a challenge here since currently, the compute mock couldn't update anything in the networking mock. Solved it by passing in the networking client into the compute mock. Felt better than passing in the port map or similar.
/cc @rifelpet