Adding support for permission boundaries for AWS IAM Roles

[victorfrancax1]

Refs #7286
Also adding Terrraform and Cloudformation support.

[k8s-ci-robot]

Welcome @victorfrancax1!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @victorfrancax1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

/ok-to-test
/cc @rifelpet

[rifelpet]

overall this looks good. Can you add an integration test case for this? It should just involve setting the new api field with a dummy value in the two in-*.yaml files here and running ./hack/update-expected.sh and the terraform and cloudformation files in the same directory should be updated to match.

My only question is around the API design. Would it make sense to ever have separate permission boundaries for the master role vs the node role? If so we'd want the API to be able to support that.

[victorfrancax1]

Hey @rifelpet , thanks for reviewing! I added an integration test case as requested.

About the API design: although being possible, it's seems very unlikely to me that people would need to set permission boundaries per instance role, since they were designed mainly to prevent privilege escalation. The furthest I would go personally is configuring different boundaries for each cluster, which is supported by this implementation. As stated by the author of the original issue (can't tag him here for some reason), should an edge case arise, we could suggest that they provide their own roles to kops. What do you think?

[hakman]

/test pull-kops-e2e-k8s-containerd

[rifelpet]

one last comment and I think this will be good to merge :) thanks for adding this!

[rifelpet]

/lgtm
/approve

This will land in Kops 1.19. I believe there will be another alpha release soon if you want to use it in an official build.

Thanks again!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, victorfrancax1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rifelpet]

One more thing @victorfrancax1 would you mind adding some docs here? This can be done in a separate PR.