Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash patch versions of old release notes #9770

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Squash patch versions of old release notes #9770

merged 4 commits into from
Aug 19, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 17, 2020 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2020
@hakman
Copy link
Member Author

hakman commented Aug 17, 2020

/hold for feedback
/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet August 17, 2020 06:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@rifelpet
Copy link
Member

This seems reasonable to me. Maybe our theme supports having submenu items on the left where we could hide some of the oldest releases behind an "archives" section. Something to consider for a followup

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@johngmyers
Copy link
Member

Ah, so you deleted the dead link.
/lgtm

@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

Ah, so you deleted the dead link.

Yes, this way the notes are kept as is, but the scripts and the link are gone.

@hakman
Copy link
Member Author

hakman commented Aug 19, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 548beeb into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
@hakman hakman deleted the squash-rel-notes branch August 19, 2020 04:50
@hakman hakman mentioned this pull request Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@mikesplain mikesplain Awaiting requested review from mikesplain

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @rifelpet @johngmyers