Remove unused Tags and FSRoot from NodeUp #9737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
rifelpet
reviewed
Aug 12, 2020
| CacheDir string | ||
| RunTasksOptions fi.RunTasksOptions | ||
| Command []string | ||
| } | ||
|
|
||
| func (i *Installation) Run() error { | ||
| distribution, err := distros.FindDistribution(i.FSRoot) | ||
| _, err := distros.FindDistribution("/") |
There was a problem hiding this comment.
I think we could get rid of the string argument in FindDistribution() since it is only ever passed "/"
There was a problem hiding this comment.
Maybe we want to add some tests for it in the future, or use in some container?
johngmyers
reviewed
Aug 13, 2020
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup