-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calico: Upgrade the "k8s-ec2-srcdst" controller to version v0.3.0 #9647
Calico: Upgrade the "k8s-ec2-srcdst" controller to version v0.3.0 #9647
Conversation
Welcome @seh! |
Hi @seh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thanks for the update! We'll want to make sure this is included in Kops 1.18 as well. |
Upgrading the "k8s-ec2-srcdst" controller to this latest version allows it to work correctly with the objects containing the new "metadata.managedFields" field introduced in Kubernetes version 1.18.0. The previous container image versions used a version of the "client-go" library that was too old to consume these fields correctly, causing the controller to fail repeatedly when trying to read Node objects retrieved from the Kubernetes API server.
339057c
to
9a5e546
Compare
Ah, I missed that. Please confirm that this change takes care of that properly. |
Look good now. Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, seh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pstream-release-1.18 Automated cherry pick of #9647: Calico: upgrade "k8s-ec2-srcdst" to version v0.3.0
Upgrading the k8s-ec2-srcdst controller to this latest version allows it to work correctly with the objects containing the new "metadata.managedFields" field introduced in Kubernetes version 1.18.0, per ottoyiu/k8s-ec2-srcdst#17.
The previous container image versions used a version of the client-go library that was too old to consume these fields
correctly, causing the controller to fail repeatedly when trying to read Node objects retrieved from the Kubernetes API server.