Replace custom codegen package with gengo

[johngmyers]

This uncovered that the OpenStack SecurityGroupRule task had hand-edited "generated" code. My attempt to fix it may well be incorrect.

/kind cleanup

[johngmyers]

The verify-gomod failure has me stumped.

[hakman]

I guess this solves the mystery of why dependencies were flaky with launch templates. 😄

[hakman]

The verify-gomod failure has me stumped.

make gomod contains a few workaround and replaces go mod vendor. You should be ok just running that and pushing the changes. I did a quick test in #9634 and seems fine.

kops/Makefile

Lines 364 to 373 in 26aa335

	.PHONY: gomod
	gomod: gomod-prereqs
	GO111MODULE=on go mod vendor
	# Switch weavemesh to use peer_name_hash - bazel rule-go doesn't support build tags yet
	rm vendor/github.com/weaveworks/mesh/peer_name_mac.go
	sed -i -e 's/peer_name_hash/!peer_name_mac/g' vendor/github.com/weaveworks/mesh/peer_name_hash.go
	# Remove all bazel build files that were vendored and regenerate (we assume they are go-gettable)
	find vendor/ -name "BUILD" -delete
	find vendor/ -name "BUILD.bazel" -delete
	make gazelle

[johngmyers]

I'm not confident of my change to SecurityGroupRule. The requirement appears to be for every Task to have a unique value in a field called Name. I'd appreciate a PR before this one that adds that field and modifies all the code that creates a SecurityGroupRule to supply it.

@zetaab @olemarkus

[johngmyers]

Since the SecurityGroupRule boilerplate was hand-edited, moved it out of the _fitask.go file.

[rdrgmnzs]

This is great, thank you @johngmyers !

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johngmyers,rdrgmnzs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

In case @johngmyers wants some feedback from @zetaab or @olemarkus .
/hold

[johngmyers]

I moved the hand-edited SecurityGroupRole boilerplate out of scope, so I no longer need feedback from @zetaab or @olemarkus. It can either remain out of scope or be moved back to being autogenerated in a later PR.

/hold cancel