Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int to string conversions #9630

Merged
merged 1 commit into from
Jul 26, 2020
+2 −2
Merged

Fix int to string conversions #9630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/instancegroups/rollingupdate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func makeGroup(groups map[string]*cloudinstances.CloudInstanceGroup, k8sClient k

var instanceIds []*string
for i := 0; i < count; i++ {
id := name + string('a'+i)
id := name + string(rune('a'+i))
var node *v1.Node
if role != kopsapi.InstanceGroupRoleBastion {
node = &v1.Node{
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/cloudup/awsup/machine_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (m *AWSMachineTypeInfo) EphemeralDevices() []*EphemeralDevice {
// TODO: What drive letters do we use?
klog.Fatalf("ephemeral devices for > 20 not yet implemented")
}
d.DeviceName = "/dev/sd" + string('c'+i)
d.DeviceName = fmt.Sprintf("/dev/sd%c", 'c'+i)
d.VirtualName = fmt.Sprintf("ephemeral%d", i)

disks = append(disks, d)
Expand Down