-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go 1.14.4 #9499
Upgrade to go 1.14.4 #9499
Conversation
We may have to update the required statuses in test-infra which means any open PRs would need to rebase :/ unless we decide to drop the jobs being added/removed from being required for some period of time. what if, for a long term solution, we used a different term instead of the go version in the GHA job name? like:
suggesting that we have a "primary" and "secondary" go versions. That way we can bump Go or OS versions without adjusting the required status contexts. thoughts? |
f635c64
to
78b57bd
Compare
Using "primary"/"secondary" would have the consequence of allowing a merge based on a GHA job that ran with an older go version. That might be okay, since it's only macos where we don't have Prow coverage. |
Yea that's true. I suppose we had the same limitation with Travis before GHA. Regardless I think we'll need to remove at least some of the GHA jobs from the required statuses and we'll need to wait some time before readding the new jobs' names in order to minimize disruption of other open PRs. |
Certainly allowing merges based on runs with older Go versions is better than allowing merges with failed runs. |
With #9552 merged this has been simplified a bit and is ready for review |
|
||
env GOBIN="${WORK_DIR}/go/bin" GOPATH="${WORK_DIR}/go/" go install -v k8s.io/code-generator/cmd/conversion-gen/ | ||
env GOBIN="${WORK_DIR}/go/bin" GOPATH="${WORK_DIR}/go/" go install -mod=mod -v k8s.io/code-generator/cmd/conversion-gen/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this should be mod or vendor? But I don't think it's a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not vendoring k8s.io/code-generator so I believe this was always installing from upstream or the module cache. It might be a good idea to vendor it by adding it to tools.go but that can happen in a followup PR.
This LGTM, but I'm afraid there's a conflict on the makefile /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
k/k 1.19 is using go 1.14.4 so this updates kops to match. kubernetes/kubernetes#88638
Using these PRs as a reference: #8882 #8886
Depends on #9428
also reverts #9396 since it is no longer needed (go 1.14's default behavior changed)