Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BootstrapScript into a Task #9449

Merged
merged 3 commits into from
Jun 28, 2020
Merged

Refactor BootstrapScript into a Task #9449

merged 3 commits into from
Jun 28, 2020

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from drekle and zetaab June 27, 2020 01:03
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider labels Jun 27, 2020
@johngmyers johngmyers changed the title WIP Refactor BootstrapScript into a Task Refactor BootstrapScript into a Task Jun 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2020
@justinsb
Copy link
Member

It's great to see this now following the patterns of the other tasks.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit d461bfd into kubernetes:master Jun 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 28, 2020
@johngmyers johngmyers deleted the userdata-task branch June 29, 2020 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drekle drekle Awaiting requested review from drekle

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@olemarkus olemarkus

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @olemarkus @justinsb @k8s-ci-robot