Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Add missing lifecycle to awstasks.SecurityGroup #9445

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Jun 25, 2020

This PR aligns the Spotinst Instance Group model with the AWS one by adding the missing Lifecycle field to awstasks.SecurityGroup for every additional security group.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/spotinst Issues or PRs related to spotinst provider approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2020
@hakman
Copy link
Member

hakman commented Jun 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit ee5d460 into kubernetes:master Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 25, 2020
@liranp liranp deleted the fix-spot-sec-lifecycle branch June 25, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants