Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dns selectors for older k8s #9431

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix dns selectors for older k8s #9431

merged 1 commit into from
Jun 23, 2020

Conversation

olemarkus
Copy link
Member

Use kubernetes.io/role instead of kubernetes.io/arch as nodeselector. This will work for all supported versions of K8s.
ref #9418

/cc @hakman @johngmyers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/addons labels Jun 23, 2020
@olemarkus
Copy link
Member Author

/assign @justinsb

@olemarkus olemarkus force-pushed the arm64-fix-dns-1.13 branch from 348fc2e to a930060 Compare June 23, 2020 10:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2020
@hakman
Copy link
Member

hakman commented Jun 23, 2020

Thanks @olemarkus !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 909117a into kubernetes:master Jun 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 23, 2020
@johngmyers
Copy link
Member

@olemarkus k8s 1.11 is still broken. It's scheduling the pods but the containers aren't becoming ready. Perhaps walk back the 1.6 template to simply directly use the amd64 images? I don't think we're likely to support ARM on k8s 1.11.

This was referenced Aug 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@justinsb justinsb

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@olemarkus @hakman @rifelpet @k8s-ci-robot @johngmyers @justinsb