Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lyft config file to Go code #9410

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Refactor lyft config file to Go code #9410

merged 2 commits into from
Jun 20, 2020

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/nodeup labels Jun 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from hakman and rdrgmnzs June 20, 2020 06:19
@olemarkus
Copy link
Member

Thanks for this!
This template stuff just for the lyft plugin was bothering me as well.

@hakman
Copy link
Member

hakman commented Jun 20, 2020

I am very happy to see this one go too. I think now we can even remove the tags usage from NodeUp. 🍾

@hakman
Copy link
Member

hakman commented Jun 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@johngmyers
Copy link
Member Author

And thanks @olemarkus for extracting LoadLyftTemplateFunctions() into lyft.go. It made this much easier than the first time I attempted it.

@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 10553e1 into kubernetes:master Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 20, 2020
@johngmyers johngmyers deleted the refactor-lyft branch June 20, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@johngmyers @olemarkus @hakman @rifelpet @k8s-ci-robot