Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add master and node image options when creating a cluster #9407

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Add master and node image options when creating a cluster #9407

merged 2 commits into from
Jun 20, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 19, 2020

As discussed during office hours, we decided to add these new options to help test ARM64 deployments.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@olemarkus
Copy link
Member

I wonder if there should be some documentation or some indication of what happens if both --image and the new flags are set. What happens now is intuitive, but it doesn't hurt to be explicit.

/assign @rifelpet
/assign @justinsb too as there are new flags involved.

@olemarkus
Copy link
Member

/assign @justinsb

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@hakman @rifelpet
Address review comments
279fd31 
Co-authored-by: Peter Rifel <[email protected]>
@hakman hakman force-pushed the master-node-image branch from d5e3249 to 279fd31 Compare June 20, 2020 16:34
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit a5b47e9 into kubernetes:master Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 20, 2020
@hakman hakman deleted the master-node-image branch July 1, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@olemarkus olemarkus

@justinsb justinsb

@rifelpet rifelpet

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@hakman @johngmyers @olemarkus @rifelpet @k8s-ci-robot @justinsb