Issue aws-iam-authenticator cert in nodeup #9378
Conversation
k8s-ci-robot
added
cncf-cla: yes
| } | ||
| c.AddTask(issueCert) | ||
| certificate, privateKey, _ := issueCert.GetResources() |
There was a problem hiding this comment.
Oh that's cool - it's a future, but we don't have to treat it specially :-)
There was a problem hiding this comment.
At least not for File. The consumer does need to know to check it in its GetDependencies().
| @@ -120,11 +124,28 @@ func (i *IssueCert) AddFileTasks(c *fi.ModelBuilderContext, dir string, name str | |||
| } | |||
|
|
|||
| func (e *IssueCert) Run(c *fi.Context) error { | |||
| // Skew the certificate lifetime by up to 30 days based on information about the generating node. | |||
| // This is so that different nodes created at the same time have the certificates they generated | |||
| // expire at different times, but all certificates on a given node expire around the same time. | |||
There was a problem hiding this comment.
Oh! Now I get why you used the network interfaces - so that the skew is constant for a given machine!
|
Thanks @johngmyers /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
/retest |
No description provided.