Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue kube-scheduler and kube-controller-manager certs in nodeup #9313

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Issue kube-scheduler and kube-controller-manager certs in nodeup #9313

merged 3 commits into from
Jun 11, 2020

Conversation

johngmyers
Copy link
Member

Need to research how to make the golden output more readable/useful.

/cc @justinsb

@k8s-ci-robot k8s-ci-robot requested a review from justinsb June 9, 2020 06:16
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 9, 2020
@johngmyers johngmyers force-pushed the refactor-scheduler-cert branch from a92cd0c to 1f4e40f Compare June 9, 2020 06:21
@justinsb
Copy link
Member

justinsb commented Jun 9, 2020

This actually looks really good to me. It doesn't have the generated keys themselves, which was always going to be the concern :-)

I did try two things: I wrapped pkix.Name so we could avoid all the nils e.g. PostalCode: null , and then I added some omitempty directives to TaskDependentResource just to clean up a few more nils:
justinsb@bd51fb4

Personally I think this looks really good at this point - very clear. Do you think we need to do more here @johngmyers ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2020
@johngmyers johngmyers force-pushed the refactor-scheduler-cert branch from a3184f1 to a1421c2 Compare June 10, 2020 03:19
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2020
@johngmyers johngmyers force-pushed the refactor-scheduler-cert branch from a1421c2 to bf11a65 Compare June 10, 2020 03:24
@johngmyers johngmyers changed the title WIP: Issue kube-scheduler cert in nodeup Issue kube-scheduler adn kube-controller-manager certs in nodeup Jun 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2020
@johngmyers johngmyers changed the title Issue kube-scheduler adn kube-controller-manager certs in nodeup Issue kube-scheduler and kube-controller-manager certs in nodeup Jun 10, 2020
@johngmyers johngmyers force-pushed the refactor-scheduler-cert branch 4 times, most recently from d604212 to 6b015a9 Compare June 10, 2020 04:59
@johngmyers johngmyers force-pushed the refactor-scheduler-cert branch from 6b015a9 to d8970b9 Compare June 10, 2020 05:45
justinsb
justinsb reviewed Jun 11, 2020
View reviewed changes
upup/pkg/fi/nodeup/nodetasks/issue_cert.go
@@ -28,13 +28,25 @@ import (
"k8s.io/kops/upup/pkg/fi"
)

// PKIXName is a simplified form of pkix.Name, for better golden test output
type PKIXName struct {
fi.NotADependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea 👍

@justinsb
Copy link
Member

Thanks @johngmyers - this is looking really good

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 98d1f7b into kubernetes:master Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 11, 2020
@johngmyers johngmyers deleted the refactor-scheduler-cert branch June 11, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @justinsb @k8s-ci-robot