Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we have IAM bucket permissions to other S3 buckets #9274

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Ensure we have IAM bucket permissions to other S3 buckets #9274

merged 1 commit into from
Jun 5, 2020

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jun 5, 2020

If we are expected to write to other buckets, we need to have suitable
permissions to e.g. determine their location.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from hakman and johngmyers June 5, 2020 02:19
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@justinsb justinsb force-pushed the make_sure_permissions_on_all_s3_buckets branch from fa4e811 to f8d2e86 Compare June 5, 2020 02:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2020
@justinsb
Copy link
Member Author

justinsb commented Jun 5, 2020

This will be useful both if we want to split the etcd backup bucket or if we want to auto-upload the JWKS documents to a public bucket as in #9271 (cc @rifelpet )

@justinsb
Ensure we have IAM bucket permissions to other S3 buckets
1e55961 
If we are expected to write to other buckets, we need to have suitable
permissions to e.g. determine their location.
@justinsb justinsb force-pushed the make_sure_permissions_on_all_s3_buckets branch from f8d2e86 to 1e55961 Compare June 5, 2020 02:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2020
@hakman
Copy link
Member

hakman commented Jun 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2020
@johngmyers
Copy link
Member

Would have been good to add a test that would have failed without the code change.

@k8s-ci-robot k8s-ci-robot merged commit 7b8a9a5 into kubernetes:master Jun 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @k8s-ci-robot @hakman @johngmyers