Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Kops for multi-architecture support #9216

Merged
merged 5 commits into from
Jun 5, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 30, 2020

The multi-architecture (ARM64) support will be a larger change. Sorting out these things in advance will make it simpler. #8938 (comment)

Each commits takes care of a certain aspect.

/cc @justinsb @mikesplain @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/nodeup labels May 30, 2020
@hakman hakman force-pushed the prepare-multi-arch branch from fd59fce to 710a9e5 Compare May 30, 2020 14:21
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2020
@hakman hakman force-pushed the prepare-multi-arch branch from 1b05e40 to d18471f Compare May 31, 2020 12:10
@johngmyers
Copy link
Member

If it weren't for kube-proxy, we could keep a concept of "the arch for the masters", but as it is we'll have to figure out how to pick the right kube-proxy image for the node's arch.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2020
@hakman hakman force-pushed the prepare-multi-arch branch from d18471f to 3eda07a Compare June 3, 2020 14:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@hakman
Copy link
Member Author

hakman commented Jun 3, 2020

Rebasing after #9258.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@hakman
Copy link
Member Author

hakman commented Jun 3, 2020

Thanks @johngmyers !

@johngmyers
Copy link
Member

Now that I think about it, a package is likely to be good for either one architecture or all architectures. A slice doesn't make much sense.

@hakman
Copy link
Member Author

hakman commented Jun 3, 2020

@johngmyers This may explain better my changes for the loading of multi-arch images:
hakman@74e51d6

At this point Kops will pull hashes for both AMD and ARM and forward them to NodeUp and NodeUp will choose which ones to load based on the "detected" architecture.

@johngmyers
Copy link
Member

Ah, packageVersion.Architectures is already a slice. I was saying it would make more sense if it were a single value with a reserved value for "all architectures".

@hakman
Copy link
Member Author

hakman commented Jun 3, 2020

For distros we use the empty / null value as "all". I think we can live with it as is for now and optimise later more. I also doubt that the slice part will help much also.

@rifelpet
Copy link
Member

rifelpet commented Jun 5, 2020

looks good!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@hakman
Copy link
Member Author

hakman commented Jun 5, 2020

Thanks a lot for going through this @rifelpet 😄

@k8s-ci-robot k8s-ci-robot merged commit 9e4bf16 into kubernetes:master Jun 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 5, 2020
@hakman hakman deleted the prepare-multi-arch branch June 5, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants