-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Kops for multi-architecture support #9216
Conversation
fd59fce
to
710a9e5
Compare
1b05e40
to
d18471f
Compare
If it weren't for kube-proxy, we could keep a concept of "the arch for the masters", but as it is we'll have to figure out how to pick the right kube-proxy image for the node's arch. /lgtm |
d18471f
to
3eda07a
Compare
Rebasing after #9258. |
/lgtm |
Thanks @johngmyers ! |
Now that I think about it, a package is likely to be good for either one architecture or all architectures. A slice doesn't make much sense. |
@johngmyers This may explain better my changes for the loading of multi-arch images: At this point Kops will pull hashes for both AMD and ARM and forward them to NodeUp and NodeUp will choose which ones to load based on the "detected" architecture. |
Ah, |
For distros we use the empty / null value as "all". I think we can live with it as is for now and optimise later more. I also doubt that the slice part will help much also. |
looks good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks a lot for going through this @rifelpet 😄 |
The multi-architecture (ARM64) support will be a larger change. Sorting out these things in advance will make it simpler. #8938 (comment)
Each commits takes care of a certain aspect.
/cc @justinsb @mikesplain @rifelpet