-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuration of the calico IP_AUTODETECTION_METHOD and IP6_AUTODETECTION_METHOD #9175
Enable configuration of the calico IP_AUTODETECTION_METHOD and IP6_AUTODETECTION_METHOD #9175
Conversation
Hi @mtl-wgtwo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @geojaz The bot tells me I should ping you! |
/ok-to-test |
I see this in the build errors:
Can someone please point me in the direction of how I would handle "manual conversion" of this? |
@mtl-wgtwo you should run |
One more thing that may help: c36470f. |
@mtl-wgtwo You need to also add the fields to the v1alpha2 api. See https://github.com/kubernetes/kops/blob/master/docs/development/api_updates.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the
Since you are changing the templates, please bump the version in bootstrapchannelbuilder: kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go Lines 728 to 729 in 4f207e4
|
@johngmyers Thanks for the pointers to the bits I wasn't aware of. I'll get this turned around. |
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
/test pull-kops-e2e-kubernetes-aws |
I'm not sure if the failing tests have anything to do with this change. I can't see why this change would affect just these two things and not anything else. [k8s.io] PrivilegedPod [NodeConformance] should enable privileged commands [LinuxOnly] |
the test failure is a flake. retrying the test should (eventually) succeed /retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the field.InternalError
nit is the only potential blocker.
/lgtm |
@hakman Is there anything you need from me to finalize this one? |
It's ok also from my point of view. There is quite a long queue of PRs so it may take some time to get the approval to merge. Thanks @mtl-wgtwo. |
@@ -100,6 +100,7 @@ require ( | |||
github.com/zclconf/go-cty v1.3.1 | |||
go.uber.org/zap v1.10.0 | |||
golang.org/x/crypto v0.0.0-20200220183623-bac4c82f6975 | |||
golang.org/x/net v0.0.0-20200202094626-16171245cfb2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i looked this up and this is already a transitive dependency so it is already present in go.sum and vendor. Thats why making it a direct dependency only results in a change to go.mod 👍
👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtl-wgtwo, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By default, Calico auto-detects the IP address to bind to from the IP addresses available on the host using a "first-found" policy. This works, except when it doesn't. This will sometimes fail on hosts that have multiple interfaces. To work around this, Calico allows setting the IP_AUTODETECTION_METHOD environment variable and customizing how it selects the right IP address.
This PR adds the environment variables IP_AUTODETECTION_METHOD and IP6_AUTODETECTION_METHOD to the DaemonSet config and adds some api variables for this so they can be customized in the cluster yaml.
I'm not a kops expert by any means, so if there is a better way to do this please let me know.