Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try validating multiple times before updating instancegroup #9165

Merged
merged 3 commits into from
May 29, 2020
Merged

Try validating multiple times before updating instancegroup #9165

merged 3 commits into from
May 29, 2020

Conversation

johngmyers
Copy link
Member

My alternative to #8897

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2020
@johngmyers
Copy link
Member Author

/cc @granular-ryanbonham

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2020
@granular-ryanbonham
Copy link
Contributor

granular-ryanbonham commented May 26, 2020 •
edited
Loading

/approve

@granular-ryanbonham
Copy link
Contributor

@johngmyers I can no longer approve, so we will need additional eyes on this..

@johngmyers @rifelpet
fix missing space
dd884a6 
Co-authored-by: Peter Rifel <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: granular-ryanbonham, johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2a613f1 into kubernetes:master May 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 29, 2020
@johngmyers johngmyers deleted the retry-initial branch May 29, 2020 19:09
@johngmyers johngmyers mentioned this pull request Jun 17, 2020
Closed
@johngmyers johngmyers mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@granular-ryanbonham granular-ryanbonham granular-ryanbonham left review comments

@rifelpet rifelpet rifelpet left review comments

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

@granular-ryanbonham granular-ryanbonham

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @granular-ryanbonham @rifelpet @k8s-ci-robot