-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS file #9105
Update OWNERS file #9105
Conversation
I think I'm on board with this, in principal getting more reviewers makes sense and involving approvers makes sense as well. K/k takes this approach and most approvers are reviewers, given the changes to blunderbuss. That said, I'm a bigger fan of involving newer contributors and motivating them to get involved. Since most of kops reviewers/approvers aren't compensated for their efforts, I'm not sure it's a 1 to 1 comparison and I do think we should be cautious since kops reviews are certainly different. We should probably consider creating a review guide as well. I do think theres something to be said about stats for a year can be limiting; a number of the people being migrated to emeritus are still top contributors given their history in the project. I'm not opposed to migrating some of them, given they seem to have moved on, just simply bringing it up out of caution. Since the emeritus term implies they may be re-migrated if they decide to get involved again, I'm not overly concerned, just figured I would bring it up. Anyway I think I support this and appreciate you gathering both data and proposing a change @johngmyers. Given the breath of changes, I suggest we get at least a majority of approvers on this. Marking hold for that purpose and holding my lgtm until others chime in. Thanks! /hold |
Tagging those affected by the current proposal and not previously tagged:
|
/lgtm |
Given my current schedule: Hope to be back rather soon and keep it up to all the new and current ones :-) |
Landing as per unanimous decision during Kops office hours 05/22. Thanks @johngmyers ! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, johngmyers, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I ran some stats: looking at pull requests with
updated:2019-05-01..2020-05-01
I counted the number of PRs that each of the existing approvers approved (either by commenting/approve
or by authoring the PR) and the number of PRs that each person left a/lgtm
comment on.Based on that, I propose moving some approvers to emeritus status.
The remaining approvers I added to the reviewers list, excepting @justinsb and @rifelpet. I'd like to reserve @justinsb's time for things that require his expertise and don't think we need to ask more of @rifelpet.
I then propose adding myself and @hakman to the reviewers list and removing @robinpercy.