Remove support for CoreOS and Jessie

[johngmyers]

No description provided.

[hakman]

This should also be removed:

kops/upup/pkg/fi/nodeup/nodetasks/package.go

Lines 340 to 344 in d5e3e15

	// Only Debian releases newer than Jessie can install .deb via apt-get
	// TODO: Refactor this function when Jessie support is dropped (duplicated code)
	if t.HasTag(tags.TagOSDebianJessie) {
	args = []string{"dpkg", "-i"}
	} else {

And this:

kops/upup/pkg/fi/nodeup/tags/tags.go

Line 23 in 3b54cfc

TagOSDebianJessie = "_jessie"

[hakman]

I think this can also be removed:

kops/pkg/apis/kops/validation/aws.go

Lines 103 to 107 in 759e24a

	if strings.Contains(ig.Spec.Image, "jessie") {
	errString := fmt.Sprintf("%s cannot use machineType %s with image based on Debian jessie.", ig.Name, machineType)
	allErrs = append(allErrs, field.Forbidden(fieldPath, errString))
	continue
	}

[hakman]

/lgtm

[rifelpet]

Nice work. I wonder if theres anything we can do to surface the error earlier, so that users that don't read the release notes aren't confused why their rolling-update cluster is failing to validate after the first node is being replaced.

I see awsValidateAMIforNVMe was using the name of the image which is far from complete coverage but I wonder if doing something similar would be "good enough" coverage to prevent the majority of support inquiries.

[hakman]

@rifelpet we have similar thing to instance type validation there. IMHO, we should do it in apply, where we can get the image name and owner account even for the AMI. Still I would do it in a subsequent patch.

[johngmyers]

@justinsb this PR is intended for 1.18. We shouldn't support these EOL distros for 1.18.

[hakman]

I think that we agreed during last office hours to include this in 1.18. Should this be merged as is, or there are any other issues to be addressed?

[justinsb]

/milestone 1.18

[k8s-ci-robot]

@justinsb: The provided milestone is not valid for this repository. Milestones in this repository: [backlog, v1.15, v1.16, v1.17, v1.18, v1.19]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justinsb]

/milestone v1.18

[rdrgmnzs]

Do we want to remove the references in the two files bellow in a separate PR?
kops/upup/pkg/fi/nodeup/nodetasks/service.go
cmd/kops/update_cluster.go

There's also a few references to CoreOS in the docs that we may want to cleanup separately to minimize any confusion.

Otherwise this LGTM.

[johngmyers]

Digital Ocean still defaults to a CoreOS image.

openstack.md says it defaults to CoreOS, but I don't see any code that makes this so.

Someone else will have to tackle docs/examples/coreos-kops-tests-multimaster.md

[hakman]

/lgtm

[hakman]

#9181 will address the default image for DO.

[rifelpet]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/retest

[johngmyers]

/retest

[johngmyers]

/retest

[hakman]

/retest

[johngmyers]

The SIG-Storage flakes are strong today.
/retest

[hakman]

Feels like Jan all over again 😄