Update to kubernetes 1.18.1 dependencies #8879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/api
area/rolling-update
approved
justinsb
force-pushed
the
update_gomod_for_k8s_1_18
branch
from
d24604f to
c4ee806
Compare
justinsb
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Adding as WIP because controller-runtime doesn't build with 1.18 libraries. |
justinsb
force-pushed
the
update_gomod_for_k8s_1_18
branch
4 times, most recently
from
4796687 to
ddfeca5
Compare
justinsb
force-pushed
the
update_gomod_for_k8s_1_18
branch
from
41a5281 to
375a3f4
Compare
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
The latest (master) of controller-runtime actually does support 1.18, so we can update after all! |
|
@justinsb now that v1.18.1 was release, should we just use that instead of v.1.18.0? |
With `make apimachinery`
The client-go signature for most methods adds a context.Context object, and also makes Options mandatory. Feed through a context.Context through many of our methods (but use context.TODO to stop it getting totally out of hand!)
Version not yet tagged, sadly.
apimachinery now requires go 1.13
justinsb
force-pushed
the
update_gomod_for_k8s_1_18
branch
from
375a3f4 to
f996d4e
Compare
justinsb
changed the title
|
Good call @hakman - updated to 1.18.1 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@justinsb seems that this broke 1.10 and 1.11. I am not really sure what happens with the mount part to be able to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.