Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uploading of file assets #8694

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix uploading of file assets #8694

merged 1 commit into from
Mar 10, 2020

Conversation

johngmyers
Copy link
Member

Attempts to run the assets phase to copy file assets results in errors such as:

W0307 21:31:28.450047    2220 executor.go:130] error running task "CopyFile/https://kubeupv2.s3.amazonaws.com/kops/1.15.0/linux/amd64/utils.tar.gz" (8m57s remaining to succeed): unable to transfer "https://kubeupv2.s3.amazonaws.com/kops/1.15.0/linux/amd64/utils.tar.gz" to "https://REDACTED.s3.amazonaws.com/file-assets/kops/1.15.0/linux/amd64/utils.tar.gz": the sha value in "s3://file-assets/kops/1.15.0/linux/amd64/utils.tar.gz.sha256" does not match "https://kubeupv2.s3.amazonaws.com/kops/1.15.0/linux/amd64/utils.tar.gz" calculated value "sha1:ec8a939a80c3ba408a8be2d96528ac14f18aea8f"W0307

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2020
justinsb
justinsb reviewed Mar 10, 2020
View reviewed changes
util/pkg/hashing/hash.go Outdated Show resolved Hide resolved
@gjtempleton gjtempleton mentioned this pull request Mar 10, 2020
Closed
@justinsb
Copy link
Member

Thanks @johngmyers

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@gjtempleton
Copy link
Member

Can confirm that this works and resolves #8716 thanks very much @johngmyers !

@k8s-ci-robot k8s-ci-robot merged commit 5c01bff into kubernetes:master Mar 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 10, 2020
@johngmyers johngmyers deleted the fix-fileassets branch March 10, 2020 18:58
This was referenced Mar 10, 2020
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 10, 2020
@k8s-ci-robot
Merge pull request #8718 from johngmyers/automated-cherry-pick-of-#86…
872413a 
…94-upstream-release-1.17

Automated cherry pick of #8694: Fix uploading of file assets
k8s-ci-robot added a commit that referenced this pull request Mar 11, 2020
@k8s-ci-robot
Merge pull request #8720 from johngmyers/automated-cherry-pick-of-#86…
e9251ad 
…94-upstream-release-1.15

Automated cherry pick of #8694: Fix uploading of file assets
k8s-ci-robot added a commit that referenced this pull request Mar 11, 2020
@k8s-ci-robot
Merge pull request #8719 from johngmyers/automated-cherry-pick-of-#86…
678a2a4 
…94-upstream-release-1.16

Automated cherry pick of #8694: Fix uploading of file assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @justinsb @k8s-ci-robot @gjtempleton