Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to overwrite etcd settings. #8402

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Allow users to overwrite etcd settings. #8402

merged 3 commits into from
Mar 15, 2020

Conversation

rdrgmnzs
Copy link
Contributor

Allow users to overwrite etcd settings, using ENV vars.

This relies on kopeio/etcd-manager#296 being landed first and the etcd-manager image being bumped to the version containing that code.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@rdrgmnzs
Copy link
Contributor Author

/hold

Hold until kopeio/etcd-manager#296 gets merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2020
@rdrgmnzs rdrgmnzs force-pushed the etcd-setting-overwrite branch from 4d19dca to 07fc09a Compare January 27, 2020 18:09
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 27, 2020
@rdrgmnzs
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@rifelpet rifelpet mentioned this pull request Jan 31, 2020
Merged
@rifelpet
Copy link
Member

/hold for reimplementing with #8455

@rdrgmnzs rdrgmnzs force-pushed the etcd-setting-overwrite branch from 07fc09a to 2d0f557 Compare February 10, 2020 18:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2020
@rdrgmnzs rdrgmnzs force-pushed the etcd-setting-overwrite branch from 0ecb061 to a415f74 Compare February 10, 2020 22:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 10, 2020
@kubernetes kubernetes deleted a comment from k8s-ci-robot Feb 10, 2020
@kubernetes kubernetes deleted a comment from k8s-ci-robot Feb 10, 2020
@rifelpet rifelpet mentioned this pull request Feb 10, 2020
Merged
@rifelpet
Copy link
Member

Could we add a test for this? https://github.com/kubernetes/kops/tree/044196ac94c97ba1d7afbf5505620998b83c888b/pkg/model/components/etcdmanager/tests/minimal

@rdrgmnzs rdrgmnzs force-pushed the etcd-setting-overwrite branch from a415f74 to 2d74af6 Compare March 12, 2020 17:50
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/api and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2020
@rdrgmnzs rdrgmnzs force-pushed the etcd-setting-overwrite branch from 2d74af6 to 7e16cad Compare March 12, 2020 17:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2020
@rdrgmnzs
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit e7846fd into kubernetes:master Mar 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 15, 2020
@rifelpet rifelpet mentioned this pull request Mar 15, 2020
Merged
@rifelpet rifelpet mentioned this pull request Mar 26, 2020
Closed
@rifelpet rifelpet mentioned this pull request Apr 18, 2020
Closed
@jaredstehler
Copy link

any chance this could be back-ported to 1.17 or 1.16?

granular-ryanbonham pushed a commit to granular-ryanbonham/kops that referenced this pull request May 20, 2020
@rdrgmnzs @granular-ryanbonham
Cherry Pick kubernetes#8402 and kubernetes#8897
0dac38a
granular-ryanbonham added a commit to granular-ryanbonham/kops that referenced this pull request May 21, 2020
@granular-ryanbonham
Fix for Cherry kubernetes#8402 and apimachinery generated.
105a021
@elblivion elblivion mentioned this pull request Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@rdrgmnzs @k8s-ci-robot @rifelpet @jaredstehler