-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct expression typos on docs/aws.md #7733
Conversation
Welcome @gpontesss! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @gpontesss. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I did sign the CNCF CLA. i think I'm supposed to it, also: |
Replying. |
Thanks for this @gpontesss. Before we can kick off tests we need to ensure the CLA is setup properly. /check-cla |
Can you confirm you've followed these steps, the CLA is linked to this github account as well as the email address used to commit these commits? Otherwise please reach out to the CNCF's help desk. Thanks! Note, you only have to do this once to get access to all CNCF/Kubernetes projects! |
I did as described. I also checked the commit email and the email registered on the CLA. I'll try again. /check-cla |
Thanks and sorry for the CLA bot problems and then my delay in reviewing! /approve Would you mind rebasing - I can't resolve the conflict it looks like... |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gpontesss, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gpontesss if you can rebase and fix the conflicts, we can get this merged soon |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Correct expression typos and enhance text on `docs/aws.md`.
Co-authored-by: John Gardiner Myers <[email protected]>
/lgtm |
Correct expression typos and enhance text on
docs/aws.md
.Note: This is my first contribution to an open source project. I will appreciate suggestions and directions on what to do/not to do.