-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS ap-east-1 region #6835
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @wxdao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Hey @wxdao! Thanks for your contribution, before we can test or merge this we need you to sign the CLA above. Luckily, once you do this once, you'll able to contribute to any of the kubernetes projects. Let us know if you run into any issues! |
Hi mike. I'd like to get CLA ready as soon as possible. However I haven't received its register validation email for hours, not sure if I wrote down a wrong email address or their system glitched. Got no reply from their support yet, looking forward to resolve this soon. |
OK I've signed it. |
/ok-to-test |
This looks great, thanks you @wxdao /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, wxdao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm guessing we're going to want this cherry-picked back to >= 1.12, possibly even to 1.11 |
…ease-1.12 Cherry pick of #6835 onto release-1.12
This PR resolves #6832.
It has done 2 things:
DescribeRegions
function can return regions with ap-east-1 correctly.