-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Calico] Fix delay setting up ip routes in new nodes #4588
Conversation
…CALICO_K8S_NODE_REF in calico-node, this commit fixes kubernetes#3224 and kubernetes#4533
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felipejfc Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calico manifest changes LGTM
/ok-to-test |
@felipejfc Thanks for the cherry pick! How does it sound if we merge you other PR into master and then figure out if we can cherry pick this in 1.9? I am still trying to figure out how @justinsb wants to handle cherry picking into the 1.9 release branch. We do want this in kops 1.9. So if that is ok can we close this PR? |
Agreed, we definitely want this in 1.9 so we should focus on getting #4589 to merged! |
agreed and closing! |
any plans for a 1.8.2 release that includes that? |
Activate node controller in calico-kube-controllers and add CALICO_K8S_NODE_REF in calico-node, this commit fixes #3224 and #4533
Because this PR fixes critical issues, maybe some people would like to add this changes to running clusters, so I think we should create a new release "1.8.2" with it.
I'll open a separated PR for master.
@justinsb @chrislovecnm @caseydavenport @igorvpcleao