Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calico] Fix delay setting up ip routes in new nodes #4588

Closed

Conversation

felipejfc
Copy link
Contributor

Activate node controller in calico-kube-controllers and add CALICO_K8S_NODE_REF in calico-node, this commit fixes #3224 and #4533

Because this PR fixes critical issues, maybe some people would like to add this changes to running clusters, so I think we should create a new release "1.8.2" with it.

I'll open a separated PR for master.

@justinsb @chrislovecnm @caseydavenport @igorvpcleao

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felipejfc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geojaz

Assign the PR to them by writing /assign @geojaz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2018
@felipejfc
Copy link
Contributor Author

@mikesplain

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calico manifest changes LGTM

@mikesplain
Copy link
Contributor

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2018
@chrislovecnm
Copy link
Contributor

@felipejfc Thanks for the cherry pick! How does it sound if we merge you other PR into master and then figure out if we can cherry pick this in 1.9? I am still trying to figure out how @justinsb wants to handle cherry picking into the 1.9 release branch. We do want this in kops 1.9.

So if that is ok can we close this PR?

@mikesplain
Copy link
Contributor

Agreed, we definitely want this in 1.9 so we should focus on getting #4589 to merged!

@felipejfc
Copy link
Contributor Author

agreed and closing!

@felipejfc felipejfc closed this Mar 6, 2018
@thomasjungblut
Copy link

any plans for a 1.8.2 release that includes that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants