Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the details of what resources will be created #446

Merged

Conversation

yissachar
Copy link
Contributor

Fixes #394

Current output of create/update (only using small portion of output for brevity):

LaunchConfiguration launchConfiguration/master-us-east-1e.masters.foo.bar.com
LaunchConfiguration launchConfiguration/nodes.foo.bar.com
AutoscalingGroup    autoscalingGroup/nodes.foo.bar.com
AutoscalingGroup    autoscalingGroup/master-us-east-1e.masters.foo.bar.com

After this PR:

LaunchConfiguration launchConfiguration/nodes.foo.bar.com
    ImageID 282335181503/k8s-1.3-debian-jessie-amd64-hvm-ebs-2016-06-18
    InstanceType    t2.medium
    SSHKey  id:foo.bar.baz.com-2e:a2:34:3a:19:b1:b2:58:26:40:7c:a0:1a:1b:23:83
    SecurityGroups  [id:<nil>]
    AssociatePublicIP   true
    IAMInstanceProfile  id:nodes.foo.bar.com
    RootVolumeSize  20
    RootVolumeType  gp2
LaunchConfiguration launchConfiguration/master-us-east-1e.masters.foo.bar.com
    ImageID 282335181503/k8s-1.3-debian-jessie-amd64-hvm-ebs-2016-06-18
    InstanceType    t2.medium
    SSHKey  id:foo.bar.baz.com-2e:a2:34:3a:19:b1:b2:58:26:40:7c:a0:1a:1b:23:83
    SecurityGroups  [id:<nil>]
    AssociatePublicIP   true
    IAMInstanceProfile  id:masters.foo.bar.com
    RootVolumeSize  20
    RootVolumeType  gp2
AutoscalingGroup    autoscalingGroup/master-us-east-1e.masters.foo.bar.com
    MinSize 1
    MaxSize 1
    Subnets [id:<nil>]
    Tags    {k8s.io/dns/internal: api.internal.foo.bar.com, k8s.io/dns/public: api.foo.bar.com, k8s.io/role/master: 1, Name: master-us-east-1e.masters.foo.bar.com, KubernetesCluster: foo.bar.com}
AutoscalingGroup    autoscalingGroup/nodes.foo.bar.com
    MinSize 1
    MaxSize 1
    Subnets [id:<nil>]
    Tags    {KubernetesCluster: foo.bar.com, k8s.io/role/node: 1, Name: nodes.foo.bar.com}

@justinsb
Copy link
Member

So awesome - thanks @yissachar

@justinsb justinsb merged commit c7c892c into kubernetes:master Sep 17, 2016
@yissachar yissachar deleted the show-resource-creation-details branch September 18, 2016 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants