Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2535. #2549

Merged
Merged

Conversation

rdtr
Copy link
Contributor

@rdtr rdtr commented May 11, 2017

I believe now it's regarded to be better to use a declarative configuration in a file for remote backend configuration rather than passing them as arguments in the command.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @rdtr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 11, 2017
@chrislovecnm
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2017
@chrislovecnm chrislovecnm requested review from justinsb and geojaz May 13, 2017 23:48
@chrislovecnm
Copy link
Contributor

Need someone with TF experience to review ;). Probably @geojaz or @justinsb

@justinsb
Copy link
Member

I like this, but will revisit once we get 1.6.0 out the door (i.e. not a blocker?)

@chrislovecnm
Copy link
Contributor

@k8s-bot ok to test

@chrislovecnm
Copy link
Contributor

@geojaz can you review, no sure what your knowledge around TF is. Pease un-assign yourself if you are not able to.

/assign @geojaz

@justinsb
Copy link
Member

Sorry for delay on this one - looks great, particularly as we're now requiring a TF version where the old form doesn't work!

@justinsb justinsb merged commit d09dce4 into kubernetes:master Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants