Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: Update coredns to v1.11.3 #16915

Merged
merged 1 commit into from
Oct 25, 2024
Merged

dns: Update coredns to v1.11.3 #16915

merged 1 commit into from
Oct 25, 2024
+167 −167

Conversation

ataut-pai
Copy link
Contributor

@ataut-pai ataut-pai commented Oct 24, 2024 •
edited
Loading

fixes #16916

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ataut-pai / name: Adrian Taut (bae118e)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ataut-pai!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ataut-pai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 24, 2024
@ataut-pai ataut-pai mentioned this pull request Oct 24, 2024
Closed
@hakman
Copy link
Member

hakman commented Oct 24, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2024
@hakman
Copy link
Member

hakman commented Oct 24, 2024

@ataut-pai Thanks for the PR! The test failure looks like a flake.
Before we merge this, would you mind squashing your commits?

@ataut-pai
dns: Update coredns to v1.11.3
bae118e 
dns: Update coredns to v1.11.3

dns: Update coredns to v1.11.3
@ataut-pai
Copy link
Contributor Author

ataut-pai commented Oct 25, 2024 •
edited
Loading

thank you, @hakman, squashed the commits so should be ready for merge 💯 also, the previous bunch of tests before squash were 🟢

QQ: is there an ETA for the next patch release?

@hakman
Copy link
Member

hakman commented Oct 25, 2024

QQ: is there an ETA for the next patch release?

Probably in the next 1-2 weeks.

@hakman
Copy link
Member

hakman commented Oct 25, 2024

/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Oct 25, 2024

/override tests-e2e-scenarios-bare-metal

@k8s-ci-robot
Copy link
Contributor

@hakman: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • tests-e2e-scenarios-bare-metal

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-linux-amd64
  • build-macos-amd64
  • build-windows-amd64
  • deploy/netlify
  • pull-kops-build
  • pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons
  • pull-kops-e2e-k8s-aws-amazonvpc
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet
  • pull-kops-verify-terraform
  • tide
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override tests-e2e-scenarios-bare-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit d633cde into kubernetes:master Oct 25, 2024
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Oct 25, 2024
@ataut-pai ataut-pai deleted the update_coredns_image branch October 25, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

dns: CoreDNS new version available for Critical/High Fixable Library Vulnerabilities
3 participants
@ataut-pai @k8s-ci-robot @hakman