Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws: Terminate ASG instances in batches of 100 instances #16251

Merged
merged 1 commit into from
Jan 13, 2024
Merged

aws: Terminate ASG instances in batches of 100 instances #16251

merged 1 commit into from
Jan 13, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 13, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2024
@hakman
Copy link
Member Author

hakman commented Jan 13, 2024

/approve

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2024
upodroid
upodroid approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8769a84 into kubernetes:master Jan 13, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 13, 2024
@hakman hakman deleted the delete-instances-batch branch January 13, 2024 10:44
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @upodroid