Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kube-system cert-manager webhook exclusion #16221

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jan 5, 2024

Continuing to troubleshoot the cluster validation flakes in https://testgrid.k8s.io/kops-misc#kops-aws-aws-load-balancer-controller

This matchExpression was removed upstream in cert-manager/cert-manager#6129

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4540a2d into kubernetes:master Jan 5, 2024
22 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 5, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Jan 6, 2024

Looks like this finally did the trick
https://testgrid.k8s.io/kops-misc#kops-aws-aws-load-balancer-controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants