Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few log with percent w #15926

Merged
merged 2 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/kops-controller/controllers/gceipam.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (r *GCEIPAMReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct

node := &corev1.Node{}
if err := r.client.Get(ctx, req.NamespacedName, node); err != nil {
klog.Warningf("unable to fetch node %s: %w", node.Name, err)
klog.Warningf("unable to fetch node %s: %v", node.Name, err)
if apierrors.IsNotFound(err) {
// we'll ignore not-found errors, since they can't be fixed by an immediate
// requeue (we'll need to wait for a new notification), and we can get them
Expand Down
2 changes: 1 addition & 1 deletion pkg/applylib/mocks/mockkubeapiserver/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ func (r *baseRequest) writeResponse(obj interface{}) error {

if _, err := r.w.Write(b); err != nil {
// Too late to send error response
klog.Warningf("error writing http response: %w", err)
klog.Warningf("error writing http response: %v", err)
return nil
}
return nil
Expand Down
4 changes: 4 additions & 0 deletions upup/pkg/fi/cloudup/template_functions.go
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,10 @@ func (tf *TemplateFunctions) DNSControllerArgv() ([]string, error) {

if cluster.Spec.IsIPv6Only() {
argv = append(argv, "--internal-ipv6")
// We need IPv4 on GCE, because we aren't publishing IPv6 Node IPs on GCE yet
if cluster.Spec.GetCloudProvider() == kops.CloudProviderGCE {
argv = append(argv, "--internal-ipv4")
}
} else {
argv = append(argv, "--internal-ipv4")
}
Expand Down
2 changes: 1 addition & 1 deletion upup/pkg/fi/vfs_castore.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func (c *VFSCAStore) ListKeysets() (map[string]*Keyset, error) {
name := tokens[0]
loadedKeyset, err := c.loadKeyset(ctx, baseDir.Join(name))
if err != nil {
klog.Warningf("ignoring keyset %q: %w", name, err)
klog.Warningf("ignoring keyset %q: %v", name, err)
continue
}

Expand Down
Loading