-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e testing logic #15900
Fix e2e testing logic #15900
Conversation
Got a successful test run by running the following config:
|
8d7c401
to
d28ceae
Compare
c869656
to
307425c
Compare
@upodroid I added a question and some requests. I think this can be merged once all these are addressed. |
307425c
to
2f5c7c8
Compare
0b9e110
to
68ec6ea
Compare
Can we merge this today please? I addressed what we discussed at the office hours |
if d.GCPProject != "" { | ||
args = appendIfUnset(args, "--project", d.GCPProject) | ||
} | ||
// set some sane default e2e testing behaviour on gce | ||
args = appendIfUnset(args, "--gce-service-account", "default") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Google Service Account that prow runs with doesn't have permissions to make IAM changes on test projects. I can talk to @ameukam about it at a later date.
Sample failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-ci-kubernetes-e2e-cos-gce-serial-canary/1705258496510922752
68ec6ea
to
6bdefda
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Pls rerun the flaking GitHub action |
I cleaned up some logic in the kubetest2-kops deployer. Some flags are automatically enabled when testing on GCE.