Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e testing logic #15900

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Sep 11, 2023

I cleaned up some logic in the kubetest2-kops deployer. Some flags are automatically enabled when testing on GCE.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
@upodroid
Copy link
Member Author

Got a successful test run by running the following config:

kubetest2 kops \
  -v 2 \
  --up --down \
  --cluster-name arm64.k8s.local \
  --cloud-provider=gce \
  --admin-access="0.0.0.0/0" \
  --gcp-project=borg-env \
  --target-build-arch="linux/arm64" \
  --create-args="--image='ubuntu-os-cloud/ubuntu-2204-jammy-arm64-v20230908' --channel=alpha --zones=us-central1-a --node-count=2 --set=spec.cloudControllerManager.image=gcr.io/borg-env/cloud-controller-manager:918af8f9-20230907T125911" \
  --kops-version-marker=https://storage.googleapis.com/kops-ci/bin/latest-ci-updown-green.txt \
  --kubernetes-version=https://storage.googleapis.com/k8s-release-dev/ci/latest.txt \
  --kubernetes-feature-gates=GRPCContainerProbe,LegacyServiceAccountTokenTracking \
  --test=kops \
  -- \
  --ginkgo-args="--debug" \
  --test-args="-test.timeout=70m -num-nodes=0" \
  --test-package-bucket=k8s-release-dev \
  --test-package-dir=ci \
  --test-package-marker=latest.txt \
  --focus-regex="\[Conformance\]" \
  --skip-regex="\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]" \
  --parallel=30
  
 # get the kubeconfig
 kops export kubeconfig --all --admin --state gs://borg-env-state-783a
 
 #patch the ccm to run
 kubectl -n kube-system patch ds cloud-controller-manager --type=json -p='[{"op": "remove", "path": "/spec/template/spec/containers/0/command"}]'

@hakman
Copy link
Member

hakman commented Sep 11, 2023

/cc @rifelpet @justinsb

tests/e2e/kubetest2-kops/deployer/up.go Outdated Show resolved Hide resolved
@upodroid upodroid force-pushed the fix-e2e-testing branch 4 times, most recently from c869656 to 307425c Compare September 11, 2023 16:33
@hakman
Copy link
Member

hakman commented Sep 12, 2023

@upodroid I added a question and some requests. I think this can be merged once all these are addressed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2023
@upodroid
Copy link
Member Author

Can we merge this today please? I addressed what we discussed at the office hours

if d.GCPProject != "" {
args = appendIfUnset(args, "--project", d.GCPProject)
}
// set some sane default e2e testing behaviour on gce
args = appendIfUnset(args, "--gce-service-account", "default")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google Service Account that prow runs with doesn't have permissions to make IAM changes on test projects. I can talk to @ameukam about it at a later date.

Sample failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-ci-kubernetes-e2e-cos-gce-serial-canary/1705258496510922752

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@upodroid
Copy link
Member Author

/retest

@upodroid
Copy link
Member Author

Pls rerun the flaking GitHub action

@k8s-ci-robot k8s-ci-robot merged commit 06d1d89 into kubernetes:master Sep 22, 2023
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants