ENI Cleanup Improvements #15884
ENI Cleanup Improvements #15884
Conversation
This should help with VPCs containing large numbers of ENIs Signed-off-by: Peter Rifel <[email protected]>
…afterwards Signed-off-by: Peter Rifel <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/test pull-kops-e2e-cni-amazonvpc |
|
/test pull-kops-e2e-cni-amazonvpc |
|
/cc @dims |
|
/approve thanks @rifelpet |
k8s-ci-robot
added
the
lgtm
| statusFilter := &ec2.Filter{ | ||
| Name: aws.String("status"), | ||
| Values: []*string{ | ||
| aws.String(ec2.NetworkInterfaceStatusDetaching), |
There was a problem hiding this comment.
Do we care about the detaching interfaces in our case?
I think the List function is called again and again, so those detaching ENIs will become available at some point.
There was a problem hiding this comment.
No, ENIs that aren't returned won't get a resource tracker assigned. I suppose the assumption is that ENIs that are attached will be implicitly deleted once the thing they're attached to is deleted.
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Attempting to fix the scalability tests: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-aws-scale-amazonvpc-using-cl2/1699576183240265728