Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting env vars from the command line #15767

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 11, 2023

Usage:

kops edit cluster --set cluster.spec.networking.amazonVPC.env=ENABLE_PREFIX_DELEGATION=true

Closes #15759

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit f8465fb into kubernetes:master Aug 11, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 11, 2023
k8s-ci-robot added a commit that referenced this pull request Aug 11, 2023
…67-origin-release-1.27

Automated cherry pick of #15767: Allow setting env vars from the command line
@hakman hakman deleted the set_env_vars branch August 12, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to set env var when using kubetest2
3 participants