Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Add instance group tag to subnets only with Karpenter #15740

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 5, 2023

Closes #15738

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider labels Aug 5, 2023
@hakman
Copy link
Member Author

hakman commented Aug 5, 2023

/cc @johngmyers

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 68eb778 into kubernetes:master Aug 5, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 5, 2023
k8s-ci-robot added a commit that referenced this pull request Aug 5, 2023
…-upstream-release-1.27

Automated cherry pick of #15740: aws: Add instance group tag to subnets only with
@hakman hakman deleted the aws_ig_tag_subnet_karpenter branch August 7, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagLimitExceeded when creating multiple clusters with more than a combined total of 50 instance-groups
3 participants