Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go to support new AWS SSO profile #15616

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

avdhoot
Copy link
Contributor

@avdhoot avdhoot commented Jul 10, 2023

Fixes: #15308

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @avdhoot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot requested review from hakman and olemarkus July 10, 2023 21:11
@avdhoot avdhoot changed the title Fix 15308 Update aws-sdk-go to support new aws sso profile Update aws-sdk-go to support new aws sso profile Jul 10, 2023
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@avdhoot avdhoot force-pushed the aws-sdk-go-fix-15308 branch from 34e8689 to 7a6bc47 Compare July 10, 2023 21:44
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2023
@hakman
Copy link
Member

hakman commented Jul 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2023
@avdhoot
Copy link
Contributor Author

avdhoot commented Jul 11, 2023

/retest

@johngmyers
Copy link
Member

@avdhoot the test failures, particularly that for pull-kops-verify-gomod, are valid.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2023
@hakman hakman changed the title Update aws-sdk-go to support new aws sso profile Update aws-sdk-go to support new AWS SSO profile Jul 12, 2023
@hakman
Copy link
Member

hakman commented Jul 12, 2023

@avdhoot Please also squash the commits and change the message to be without "Fix 15308".

@avdhoot avdhoot force-pushed the aws-sdk-go-fix-15308 branch from abb63b3 to d5d583f Compare July 12, 2023 02:43
@hakman
Copy link
Member

hakman commented Jul 12, 2023

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1675f21 into kubernetes:master Jul 12, 2023
k8s-ci-robot added a commit that referenced this pull request Jul 13, 2023
…-upstream-release-1.27

Automated cherry pick of #15616: Update aws-sdk-go to support new aws sso profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kOps doesn't correctly pick up AWS Identity Center Credentials
4 participants