Remove references to ClusterSpec.API from nodeup #15615
Conversation
k8s-ci-robot
added
cncf-cla: yes
pkg/apis/nodeup/config.go
Outdated
| @@ -64,6 +64,8 @@ type Config struct { | |||
| KubeProxy *kops.KubeProxyConfig | |||
| // Networking configures networking. | |||
| Networking kops.NetworkingSpec | |||
| // API controls how the Kubernetes API is exposed. | |||
| API *kops.APISpec `json:",omitempty"` | |||
There was a problem hiding this comment.
Devil's advocate: are we just going to end up copying the Cluster into the nodeup.Config object? Why do we have two objects?
There was a problem hiding this comment.
We only copy fields that affect the configurations of nodes of the appropriate type. Changes to NodeupConfig result in nodes of the relevant instance group being selected for rolling update, whereas changes to the ClusterSpec do not. So since we only populate this new field for control-plane and api-server nodes, changes to the sub-fields we populate result in control-plane and api-server nodes being selected for update, but worker nodes not. Previously, no nodes would be selected for update, so control-plane and api-server nodes would continue to run with outdated configuration.
|
/retest |
johngmyers
force-pushed
the
nodeup-publicname
branch
from
bb28cb3
to
c96caa7
Compare
|
As discussed in office hours, this lgtm. /approve |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
johngmyers
force-pushed
the
nodeup-publicname
branch
from
c96caa7
to
62f7faa
Compare
k8s-ci-robot
removed
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
No description provided.