-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gce: Set firewall rules for Internal LBs also #15611
Conversation
cc @hakman I had to do this to get any access (from the bastion), but I haven't found a nice way to actually test this properly. Have you found any tricks? (Maybe running kOps on a GCE VM in the same project/network?) Edit: Actually I figured out one trick: we can scp kubectl and ~/.kube/config to the bastion and easily access the cluster from there. |
It seems we can use the exact same rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but otherwise nice find.
/lgtm
/approve
/hod in case you want to move the call to b.addFirewallRules()
outside the create*LB
functions.
@@ -215,8 +219,7 @@ func createInternalLB(b *APILoadBalancerBuilder, c *fi.CloudupModelBuilderContex | |||
}) | |||
} | |||
} | |||
|
|||
return nil | |||
return b.addFirewallRules(c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be better outside the create*LB
methods.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…15332-#15611-#15614-#15607-upstream-release-1.27 Automated cherry pick of #15602: gce: Add support for bastions#15332: gce: Update logic for internal LB#15611: gce: Set firewall rules for Internal LBs also#15614: gce: Rename firewall SSH rules for bastion#15607: gce: Use `user-data` instead of `startup-script` metadata
It seems we can use the exact same rules.