gce: Set firewall rules for Internal LBs also #15611
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
cc @hakman I had to do this to get any access (from the bastion), but I haven't found a nice way to actually test this properly. Have you found any tricks? (Maybe running kOps on a GCE VM in the same project/network?) Edit: Actually I figured out one trick: we can scp kubectl and ~/.kube/config to the bastion and easily access the cluster from there. |
It seems we can use the exact same rules.
k8s-ci-robot
added
size/L
| @@ -215,8 +219,7 @@ func createInternalLB(b *APILoadBalancerBuilder, c *fi.CloudupModelBuilderContex | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| return nil | |||
| return b.addFirewallRules(c) | |||
There was a problem hiding this comment.
This may be better outside the create*LB methods.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
changed the title
…15332-#15611-#15614-#15607-upstream-release-1.27 Automated cherry pick of #15602: gce: Add support for bastions#15332: gce: Update logic for internal LB#15611: gce: Set firewall rules for Internal LBs also#15614: gce: Rename firewall SSH rules for bastion#15607: gce: Use `user-data` instead of `startup-script` metadata
It seems we can use the exact same rules.