-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kops-controller: create IPAM controller for GCE #15591
Conversation
This is necessary (but not sufficient) for IPv6 support on GCP. (First in a sequence of PRs.) |
cmd/kops-controller/main.go
Outdated
if err != nil { | ||
return fmt.Errorf("error creating aws IPAM controller: %w", err) | ||
} | ||
if err := ipamController.SetupWithManager(mgr); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bottom-factor this out of the switch statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to define an interface, but - done!
We observe the IPv6 CIDRs assigned to nodes, and reflect them into the node. Co-authored-by: John Gardiner Myers <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We observe the IPv6 CIDRs assigned to nodes, and reflect them into the node.