-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove kube-dns-autoscaler
when upgrading to CoreDNS
#15584
docs: remove kube-dns-autoscaler
when upgrading to CoreDNS
#15584
Conversation
- there is a separate `coredns-autoscaler` that is spun up in more recent kOps versions - so the `kube-dns-autoscaler` is no longer needed after an upgrade to CoreDNS - and possibly could conflict if they both targeted the same deployment - updating the `kube-dns-autoscaler` was the most confusing part, so this simplifies things a good bit!
Hi @agilgur5. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agilgur5. Should be very useful for those that upgrade clusters.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Summary
Per #6318 (comment) and related comments, the
kube-dns-autoscaler
is no longer needed when upgrading to CoreDNS.Details
there is a separate
coredns-autoscaler
that is spun up in more recent kOps versionskube-dns-autoscaler
is no longer needed after an upgrade to CoreDNS - and possibly could conflict if they both targeted the same deploymentupdating the
kube-dns-autoscaler
was the most confusing part, so this simplifies things a good bit!also fix some minor inconsistent spacing in this doc
Misc
Was teaching folks about k8s DNS so came back to the issue to see what the progress was w/ CoreDNS as I had to do this upgrade a couple years ago